Home | Contact Us | FAQ | Search & Site Map | Link to Us
Sign In | Join | Other 45 Sites in Network
Home
DiscussionsAccessExcelInfoPathOutlookPowerPointPublisherWord
DirectoryUser Groups
Related Topics
Outlook ExpressInternet ExplorerWindowsMS Server ProductsMore Topics ...

MS Office Forum / Excel / Programming / September 2007

Tip: Looking for answers? Try searching our database.

need help with nested for-next loops

Thread view: 
Enable EMail Alerts  Start New Thread
Thread rating: 
rpw - 17 Sep 2007 20:00 GMT
Hi all,

I have a old workbook with several worksheets.  Each sheet is formatted the
same having weekly entries grouped quarterly for a 1 year period.  (Each row
is 1 week).

I have a new workbook with each week in columns.

I need to have the sum of all week 1 (cell "H5") entries from every
worksheet in the old workbook put into the week 1 cell "B6" in the new
workbook.

And then all week 2 (cell "H6") into week 2 cell "C6" and so on.

The data in the old workbook is in four ranges (H5:H17, H20:H32, H36:H48,
H52:H64) on each worksheet.  The weekly sums go into the new workbook range
of "B6:BA6".

So, how do I do this?  

Thanks in advance for any guidance provided

rpw
Joel - 17 Sep 2007 21:16 GMT
Sub getolddata()

Const OldBook = "c:\temp\Old Workbook.xls"

Workbooks.Open Filename:=OldBook
OldBkName = ActiveWorkbook.Name

Dim SumArray(52)
For Myweek = 1 To 52
  SumArray(Myweek) = 0
Next Myweek

For Each ws In Worksheets

  Set OldRange = Sheets(ws.Name). _
     Range("H5:H17,H20:H32,H36:H48")
 
  For Myweek = 1 To 52
        SumArray(Myweek) = SumArray(Myweek) + _
           OldRange(Myweek)
  Next Myweek
Next ws

For Myweek = 1 To 52
  ThisWorkbook.Sheets("Sheet1"). _
     Range("B6").Offset(0, Myweek - 1) = _
     SumArray(Myweek)
Next Myweek

Workbooks(OldBkName).Close
End Sub

> Hi all,
>
[quoted text clipped - 19 lines]
>
> rpw
rpw - 17 Sep 2007 22:48 GMT
Thanks for the quick reply Joel. I am trying to understand this and am not
sure that I do.  

"Next Myweek" is in three places.  The first "Next Myweek", I don't
understand why loop 52 times - is this clearing out any previous
SumArray(Myweek) by setting them to 0?

The second "Next Myweek" gets a runtime error # 13 Type mis-match.

The third place "Next Myweek" is used looks like it is being used to offset
the column and give the cell the value of SumArray(Myweek).

> For Myweek = 1 To 52
>    SumArray(Myweek) = 0
[quoted text clipped - 43 lines]
> >
> > rpw
rpw - 18 Sep 2007 00:18 GMT
Aha!  I found the error in the spreadsheet formula - if there was no entry
then a "" was entered otherwise a number was calculated.  VB can't sum "".  
So now I get the code and it works!  Thanks for your help in this.
Signature

rpw

> Sub getolddata()
>
[quoted text clipped - 51 lines]
> >
> > rpw
rpw - 18 Sep 2007 00:24 GMT
Correction: It works, but not like I thought it would.  The cell range being
summed is not skipping from H17 to H20 nor from H32 to H36.
Signature

rpw

> Sub getolddata()
>
[quoted text clipped - 51 lines]
> >
> > rpw
Joel - 18 Sep 2007 03:38 GMT
I made a small change and now it works.  Sorry I didn't look carefully at all
the data when I originally tested the code.

the following statement reads 52 values from the old worksheet skipping
cells as requested
  Set OldRange = Sheets(ws.Name). _
     Range("H5:H17,H20:H32,H36:H48,H52:H64")

The code takes 52 weeks of data in one worksheet and puts it in an array
SumArray.  Then goes to next worksheet and add the 52 weeks of data to the
SumAray.  The macro keeps doing this for all worksheets.  Then the macro
write the final array back in the new worksheet.

Sub getolddata()

Const OldBook = "c:\temp\Old Workbook.xls"

Workbooks.Open Filename:=OldBook
OldBkName = ActiveWorkbook.Name

Dim SumArray(52)
For MyWeek = 1 To 52
  SumArray(MyWeek) = 0
Next MyWeek

For Each ws In Worksheets

  Set OldRange = Sheets(ws.Name). _
     Range("H5:H17,H20:H32,H36:H48,H52:H64")
 
  MyWeek = 1
  For Each cell In OldRange
        SumArray(MyWeek) = SumArray(MyWeek) + _
           cell.Value
        MyWeek = MyWeek + 1
  Next cell
Next ws

For MyWeek = 1 To 52
  ThisWorkbook.Sheets("Sheet1"). _
     Range("B6").Offset(0, MyWeek - 1) = _
     SumArray(MyWeek)
Next MyWeek

Workbooks(OldBkName).Close
End Sub

> Correction: It works, but not like I thought it would.  The cell range being
> summed is not skipping from H17 to H20 nor from H32 to H36.
[quoted text clipped - 54 lines]
> > >
> > > rpw
rpw - 18 Sep 2007 16:38 GMT
Hi Joel,

Thanks again for the help and thanks also for the explanation.  This version
is working as expected and I can now see how each sum is held in memory until
it is posted in the current workbook.  Thanks, I've learned a bit more today!
:-)
Signature

rpw

> I made a small change and now it works.  Sorry I didn't look carefully at all
> the data when I originally tested the code.
[quoted text clipped - 101 lines]
> > > >
> > > > rpw
 
Sign In
Join
My Latest Posts
My Monitored Threads
My Blog
My Photo Gallery
My Profile
My Homepage

Start New Thread
Enable EMail Alerts
Rate this Thread



©2008 Advenet LLC   Privacy Policy - Terms of Use
This website includes both content owned or controlled by Advenet as well as content owned or controlled by third parties.